Fix #6371: make pip install respect --ignore-requires-python #6518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
force-pushed
the
issue-6371-ignore-requires-python
branch
from
89c9ae8 to
795946e
Compare
cjerdonek
force-pushed
the
issue-6371-ignore-requires-python
branch
from
795946e to
d71157e
Compare
|
Rebased after PR #6514. |
cjerdonek
force-pushed
the
issue-6371-ignore-requires-python
branch
from
d71157e to
5b1f797
Compare
xavfernandez
approved these changes
May 22, 2019
src/pip/_internal/index.py
Outdated
| return False | ||
|
|
||
| logger.debug( | ||
| 'Ignoring incompatible Requires-Python (%s not in: %r) ' |
There was a problem hiding this comment.
This log message could (when read quickly) lead the user to think that the link was ignored.
Maybe 'Ignoring incompatible Requires-Python check result (%s not in: %r) for link: %s' ?
There was a problem hiding this comment.
Good suggestion! I went ahead and changed it to:
Ignoring failed Requires-Python check (3.6.5 not in: '== 3.6.4') for link: ...
cjerdonek
force-pushed
the
issue-6371-ignore-requires-python
branch
from
5b1f797 to
5528d35
Compare
|
Thanks for reviewing, @xavfernandez! |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #6371.