Make VersionControl.fetch_new() an instance method #6519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjerdonek
added
C: vcs
cjerdonek
force-pushed
the
vcs-subversion-fetch-new
branch
from
bfb9d34 to
68c105c
Compare
|
Okay, thanks for the second look. |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to allow #6515 to proceed ("Properly support interactive Subversion client").
The PR changes
VersionControl.fetch_new()back to an instance method to support a new use case (originally requested in #6386). Before issue #6386, there wasn't a reason to store global state inVersionControlinstances. And with PR #6492, we can now do so.