Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude '.tox', '.nox' from being copied during 'pip install .' #6770

Merged
merged 14 commits into from
Aug 5, 2019
Merged

exclude '.tox', '.nox' from being copied during 'pip install .' #6770

Show file tree
Hide file tree
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
3626530
exclude '.tox', '.nox', '.git', '.hg', '.bzr', '.svn' from pip instal…
omry Jul 23, 2019
82e89a9
news
omry Jul 23, 2019
f285407
lint
omry Jul 23, 2019
e833052
lint take 2 (not sure how to test locally)
omry Jul 23, 2019
67ce442
fixed lint, excludes only .tox and .nox
omry Jul 23, 2019
29a8b6e
updated news
omry Jul 23, 2019
459b4dc
renamed news file to match PR
omry Jul 24, 2019
6b1aa6f
simplifies new language
omry Jul 24, 2019
d4171f2
minor updates
omry Jul 31, 2019
77c1504
unit test
omry Aug 3, 2019
e67f066
fixed on python 2.7
omry Aug 3, 2019
8e87980
responding to comments
omry Aug 3, 2019
ec47c86
updated docs
omry Aug 3, 2019
6dd5727
responded to comments
omry Aug 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions news/6770.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
'pip install .' is very slow in the presence of large directories in the source tree.
omry marked this conversation as resolved.
Show resolved Hide resolved
#6770 excludes .tox and .nox from being copied by 'pip install .', significantly speeding
up the builds when those directories are large.
11 changes: 10 additions & 1 deletion src/pip/_internal/download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -939,7 +939,16 @@ def unpack_file_url(
if is_dir_url(link):
if os.path.isdir(location):
rmtree(location)
shutil.copytree(link_path, location, symlinks=True)
shutil.copytree(link_path,
location,
symlinks=True,
# Pulling in those directories can potentially
# be very slow.
# see dicsussion at:
omry marked this conversation as resolved.
Show resolved Hide resolved
# https://github.com/pypa/pip/issues/2195
# https://github.com/pypa/pip/pull/2196
ignore=shutil.ignore_patterns('.tox', '.nox'))
omry marked this conversation as resolved.
Show resolved Hide resolved

if download_dir:
logger.info('Link is a directory, ignoring download_dir')
return
Expand Down