Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spread the Windows test load between Azure & Appveyor #6790

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Jul 25, 2019

Cf #6791 for the rationale

@xavfernandez xavfernandez added skip news Does not need a NEWS file entry (eg: trivial changes) C: tests Testing and related things OS: windows Windows specific type: maintenance Related to Development and Maintenance Processes labels Jul 25, 2019
@pradyunsg
Copy link
Member

Appveyor is angry at you Xavier.

@pfmoore
Copy link
Member

pfmoore commented Jul 26, 2019

This looks suspiciously like pypa/virtualenv#1339

You need to be very careful to get a completely up to date virtualenv when using 3.7, as behaviour changes within the (internal details of) minor versions of 3.7 repeatedly broke virtualenv. I think we got all the edge cases dealt with, but if anyone finds a new one, it'll need addressing (although @gaborbernat is rewriting virtualenv to use the core venv mechanisms, so hopefully this whole mess will be behind us soon).

@xavfernandez
Copy link
Member Author

xavfernandez commented Jul 26, 2019

Appveyor is angry at you Xavier.

Appveyor seems to be quite sensitive indeed.

This looks suspiciously like pypa/virtualenv#1339

yup, it looks like it. I moved 3.7 build to azure to avoid this (or get the same error on Azure ^^).

@xavfernandez xavfernandez force-pushed the xfernandez/even_build_times branch from fe7f2be to a66891b Compare July 26, 2019 12:23
@xavfernandez xavfernandez force-pushed the xfernandez/even_build_times branch from a66891b to 30b7720 Compare July 26, 2019 13:07
@pradyunsg
Copy link
Member

pradyunsg commented Jul 26, 2019

get the same error on Azure ^^

Ah, optimism. ;)


@pfmoore this was the issue with the behavior varying for patch versions of CPython 3.7, right?

FWIW, pip "officially" only supports the latest patch versions of each non-EOL minor version. Maybe we should use the newest CPython minor version on CI (via pyenv or equivalent), with caching to optimize performance?

@xavfernandez
Copy link
Member Author

xavfernandez commented Jul 26, 2019

Well Azure seems more sympathetic and tests seem to go smoothly.

@pfmoore
Copy link
Member

pfmoore commented Jul 26, 2019

@pradyunsg Looks like the issue is resolved. But yes, in theory we could force use of the latest version. Seems like a lot of bother though. Making sure we use the latest virtualenv should be enough.

Personally, I'm a little frustrated that this stuff got changed in CPython minor releases without proper deprecation - but it is internal details, so it's hard to get too upset (it's just that there's no supported way to implement virtualenv, using internals is necessary - I'm so looking forward to the rewrite when we can finally put all of this rubbish behind us) .

@pradyunsg
Copy link
Member

Seems like a lot of bother though. Making sure we use the latest virtualenv should be enough.

Fair enough. 🙃

@pradyunsg
Copy link
Member

Merging since no one is opposed to doing this.

@pradyunsg pradyunsg merged commit 9a700bb into pypa:master Jul 30, 2019
@pradyunsg pradyunsg mentioned this pull request Aug 4, 2019
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Aug 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Aug 29, 2019
@xavfernandez xavfernandez deleted the xfernandez/even_build_times branch September 6, 2019 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
auto-locked Outdated issues that have been locked by automation C: tests Testing and related things OS: windows Windows specific skip news Does not need a NEWS file entry (eg: trivial changes) type: maintenance Related to Development and Maintenance Processes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants