Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redact single-part login credentials from URLs #6921

Merged
merged 2 commits into from
Aug 26, 2019
Merged

Redact single-part login credentials from URLs #6921

merged 2 commits into from
Aug 26, 2019

Conversation

atugushev
Copy link
Contributor

Closes #6891

cjerdonek
cjerdonek approved these changes Aug 25, 2019
View reviewed changes
Copy link
Member

@cjerdonek cjerdonek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

news/6891.feature Outdated Show resolved Hide resolved
@cjerdonek cjerdonek added C: logging Information Logging type: enhancement Improvements to functionality type: security Has potential security implications labels Aug 25, 2019
@cjerdonek cjerdonek closed this Aug 26, 2019
@cjerdonek cjerdonek reopened this Aug 26, 2019
@atugushev
Address review comments
29e7204 
Update news entry message
@atugushev
Copy link
Contributor Author

@cjerdonek sorry, i've added [ci skip], that's why travis check has stuck :( Removed it.

@cjerdonek cjerdonek merged commit 3c9770d into pypa:master Aug 26, 2019
@cjerdonek
Copy link
Member

Thanks again, @atugushev! 🎉

PatrikKopkan pushed a commit to PatrikKopkan/pip that referenced this pull request Sep 6, 2019
@atugushev
Redact single-part login credentials from URLs (pypa#6921)
89f5adc
@atugushev atugushev deleted the fix-issue-6891 branch September 8, 2019 22:49
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Oct 8, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

@cjerdonek cjerdonek cjerdonek approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation C: logging Information Logging type: enhancement Improvements to functionality type: security Has potential security implications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redact single-part login credentials from URLs.
3 participants
@atugushev @cjerdonek @pradyunsg