Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Factor get_dist implementation out of InstallRequirement #7180

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Factor get_dist implementation out of InstallRequirement #7180

merged 1 commit into from
Oct 17, 2019

Conversation

chrahunt
Copy link
Member

With it outside of the class body and taking primitive values, this
should be easier to move into a separate module.

@chrahunt
Factor get_dist implementation out of InstallRequirement
d25dc68 
With it outside of the class body and taking primitive values, this
should be easier to move into a separate module.
@chrahunt chrahunt added type: refactor Refactoring code skip news Does not need a NEWS file entry (eg: trivial changes) labels Oct 13, 2019
@chrahunt chrahunt marked this pull request as ready for review October 13, 2019 00:56
pradyunsg
pradyunsg approved these changes Oct 17, 2019
View reviewed changes
Copy link
Member

@pradyunsg pradyunsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, not that this does much IMO but it's better than status quo!

@pradyunsg pradyunsg merged commit 554207e into pypa:master Oct 17, 2019
@chrahunt chrahunt deleted the refactor/separate-get-dist-function branch October 17, 2019 22:49
@chrahunt chrahunt mentioned this pull request Oct 25, 2019
Open
@lock lock bot added the auto-locked Outdated issues that have been locked by automation label Nov 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pradyunsg pradyunsg pradyunsg approved these changes

Assignees
No one assigned
Labels
auto-locked Outdated issues that have been locked by automation skip news Does not need a NEWS file entry (eg: trivial changes) type: refactor Refactoring code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrahunt @pradyunsg