-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Pipelines: Test Windows on Python 3.8 #7320
Conversation
Created as a draft PR because it is currently failing on 3.8: Error output
Any ideas why? |
Python 3.8 also fails on AppVeyor with the same 4 FAILs and 5 new ERRORs:
IN case they're related, the log is below and at https://ci.appveyor.com/project/hugovk/pip/builds/28736540/job/xl59c0khq23liwhv. Error output
|
^ I think this is the relevant bit of output here. |
https://twitter.com/metalikus/status/1193233990854955008 ^ seems relevant |
Hmm, still failing. AppVeyor: Azure Pipelines: |
Hello! I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the |
b54e502
to
f08dc67
Compare
In Python 3.8, expanduser on Windows no longer respects HOME, per https://bugs.python.org/issue36264.
Looks like Python 3.8 brings a change in |
@chrahunt Thanks for finishing this one up! |
For #7229.
Python 3.8 is now available on Azure Pipelines: https://github.com/microsoft/azure-pipelines-image-generation/issues/1317#issuecomment-551965427.
I wasn't sure what the logic for calculating
maxParallel
, so I incremented it in the places where I added a new 3.8 job.Please let me know if it should be adjusted.
This PR is for Windows. (See #7321 for Linux and macOS.)