Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove interpreter-specific major version tag #7355

Merged
merged 2 commits into from
Nov 16, 2019
Merged

Remove interpreter-specific major version tag #7355

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4f2c9f
Remove interpreter-specific major version tag
chrahunt Nov 15, 2019
a2d473f
Add NEWS
chrahunt Nov 16, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions news/7355.removal
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Remove interpreter-specific major version tag e.g. ``cp3-none-any``
from consideration. This behavior was not documented strictly, and this
tag in particular is `not useful <https://snarky.ca/the-challenges-in-designing-a-library-for-pep-425/>`_.
Anyone with a use case can create an issue with pypa/packaging.
3 changes: 0 additions & 3 deletions src/pip/_internal/pep425tags.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,9 +433,6 @@ def get_supported(

# No abi / arch, but requires our implementation:
supported.append(('%s%s' % (impl, versions[0]), 'none', 'any'))
# Tagged specifically as being cross-version compatible
# (with just the major version specified)
supported.append(('%s%s' % (impl, versions[0][0]), 'none', 'any'))

# No abi / arch, generic Python
for i, version in enumerate(versions):
Expand Down
14 changes: 0 additions & 14 deletions tests/functional/test_download.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,20 +620,6 @@ def test_download_specify_implementation(script, data):
in result.files_created
)

data.reset()
fake_wheel(data, 'fake-1.0-fk2.fk3-none-any.whl')
result = script.pip(
'download', '--no-index', '--find-links', data.find_links,
'--only-binary=:all:',
'--dest', '.',
'--implementation', 'fk',
'fake'
)
assert (
Path('scratch') / 'fake-1.0-fk2.fk3-none-any.whl'
in result.files_created
)

data.reset()
fake_wheel(data, 'fake-1.0-fk3-none-any.whl')
result = script.pip(
Expand Down