re-raise an ImportError exception when pip tries to import a missing module #7790
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @rohitsanj Are you still working on this PR? If not, do you mind if I take it up and finish it? |
|
Please go ahead. No one seems to be reviewing this for some reason. |
|
Hi @rohitsanj I also see that the checks are failing here. Do you want to perhaps run tests and see if they are all passing, and revisit the changes? |
|
Sorry but I'm caught up with other things. |
|
Sure, no issues @rohitsanj |
lock
bot
added
the
auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5354
I've updated the messaging and made it
raisean ImportError as suggested by @pradyunsg in this comment.