Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve docs on pinning version numbers #7820

Closed
wants to merge 1 commit into from

Conversation

m-aciek
Copy link

@m-aciek m-aciek commented Mar 4, 2020

Second take (see #7807) on improving Pinned Version Numbers documentation in User Guide.

  • Added comment # via SomePackage as a good practice example of preserving cause of presence of package,
  • added suggestion for pinning version numbers by hand using pip show,
  • added suggestion for putting sub-dependencies in constraints file to avoid installing not needed package,
  • added warnings about using pip freeze generation.

Although #7811 and #6925 would make those changes not needed, in my opinion they express best practices for pip's features as they are today and help its users to avoid pitfalls.

@m-aciek m-aciek force-pushed the improve-pinning-docs branch 4 times, most recently from ff22894 to 40b5ee6 Compare March 4, 2020 22:58
Suggest maintaining requirements file by hand before mentioning pip freeze.
@m-aciek m-aciek force-pushed the improve-pinning-docs branch from 40b5ee6 to 4f9eef5 Compare March 4, 2020 23:04
@pradyunsg pradyunsg added the type: docs Documentation related label Mar 6, 2020
@pradyunsg
Copy link
Member

May I suggest looking at #9474 and suggest if the changes made here are still relevant after the changes made to this section there? (this whole ensuring repeatability section becomes a dedicated page there, which I'm happy to update if we have agreement on any suggested changes to be made.

@github-actions github-actions bot added the needs rebase or merge PR has conflicts with current master label Aug 15, 2021
@pradyunsg
Copy link
Member

Closing this out, since this is significantly out of date. For what it's worth, There's a dedicated page for this now: https://pip.pypa.io/en/latest/topics/repeatable-installs/

If there's still interest in doing this, I encourage the interested folks to file a new PR for this. :)

@pradyunsg pradyunsg closed this Sep 18, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs rebase or merge PR has conflicts with current master type: docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants