-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include http subdirectory in 'pip cache info' and 'pip cache purge' #8910
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good to go? I guess I'll wait a bit for more eyeballs on this, but this looks great @hugovk! ^>^
It seems strange that |
They could be listed, but I'm not sure if is of any practical use. Here's mine ( 174 lines like:
And this is after I purged the http cache yesterday. It's now 54.5 MB. Before purging it was 1202.4 MB, so that'd be maybe 4,000 lines like that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
IMO This is a good PR but I'm not sure if the it closes issue mention it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's gooooo
Fixes #8892.
Example: