Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redact auth from URL in UpdatingDefaultsHelpFormatter #9163

Merged
merged 2 commits into from
Nov 27, 2020

Conversation

NoahGorny
Copy link
Contributor

Closes #9160

Copy link
Member

@xavfernandez xavfernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, a test would be nice (basically testing that PIP_INDEX_URL=https://user:[email protected] pip install --help does not contain secret).

@NoahGorny
Copy link
Contributor Author

PIP_INDEX_URL=https://user:[email protected] pip install --help

Good idea, added 😄

@xavfernandez xavfernandez added this to the 20.3 milestone Nov 26, 2020
@pradyunsg pradyunsg merged commit 8b4652e into pypa:master Nov 27, 2020
@sbidoul sbidoul mentioned this pull request Dec 1, 2020
@NoahGorny NoahGorny deleted the redact-url-from-help branch December 2, 2020 20:40
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--help output does not redact password from configured index_url
3 participants