Fix redact url in --help #9207
Merged
Fix redact url in --help #9207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahGorny
force-pushed
the
fix-redact-url-from-help
branch
from
ae3b115 to
4a19272
Compare
uranusjr
reviewed
Dec 3, 2020
Happens because we pass a list from --extra-index-url
NoahGorny
force-pushed
the
fix-redact-url-from-help
branch
from
4a19272 to
5cfd8a7
Compare
pradyunsg
approved these changes
Dec 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9191
Closes #9196
Happened as we pass a list from --extra-index-url values, and we only handled regular strings
Added a test to address this
@pradyunsg @sbidoul