Correctly implement yanking logic #9226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not return yanked versions from an index, unless the version range can only be satisfied by yanked candidates.
uranusjr
force-pushed
the
new-resolver-skip-yanked-unless-only
branch
from
f6a42a9 to
ffb3d1b
Compare
pradyunsg
approved these changes
Dec 4, 2020
|
Any ideas when a new version of PIP will be released containing this PR? |
|
Does this actually fix your issue? (Asking explicitly to be sure, since this patch does not have any tests to ensure the behaviour is correct.) |
Fixes issue with "yank" but there is some other problem as mentioned in #9203 (comment) |
This was referenced Dec 6, 2020
This was referenced Dec 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not return yanked versions from an index, unless the version range can only be satisfied by yanked candidates.
This should fix the trouble described in #9203 (comment). I don’t think this is enough for #8262 since it still involves prereleases. But that’s for another day (and if I’m understanding the code correctly, need to involve changes in
PackageFinder).I’m not sure what way is best to test this. Yanking only works with indexes, and I’m not sure how to run one for a unit test 😥