Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve SSL Certificate Verification details #9477

Merged
merged 13 commits into from
Feb 27, 2021
Merged

Conversation

bbodenmiller
Copy link
Contributor

@bbodenmiller bbodenmiller commented Jan 20, 2021

Based on details provided at #6720 (comment) by @chrahunt

  • Clarify --cert help text that setting --cert overrides default CA bundle
  • Add more details to SSL Certificate Verification section about how it works

Fix #6720

Please use squash merge option when merging.

@bbodenmiller bbodenmiller changed the title Clarify that --cert replaces default CA bundle Improve SSL Certificate Verification details Jan 20, 2021
@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 22, 2021
@uranusjr
Copy link
Member

This needs a news fragment.

@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Feb 24, 2021
@bbodenmiller
Copy link
Contributor Author

Any pointers on why CI is failing?

@uranusjr
Copy link
Member

I think you need to break the message into more lines, it's exceeding the length limit.

@bbodenmiller
Copy link
Contributor Author

I made it as short as other help texts and still seems to be failing. 🤔

news/6720.doc.rst Outdated Show resolved Hide resolved
@uranusjr
Copy link
Member

 cert = partial(
     PipOption,
-    '--cert',
-    dest='cert',
-    type='path',
-    metavar='path',
+    "--cert",
+    dest="cert",
+    type="path",
+    metavar="path",

Not sure why the linter suddenly starts to care about quotes in this function 🤔 But let’s include the suggestion anyway, since we indeed prefer double quotes.

@pradyunsg
Copy link
Member

Not sure why the linter suddenly starts to care about quotes in this function 🤔

Because this subpackage is finally enforced in CI to follow black -- see #9635.

@bbodenmiller
Copy link
Contributor Author

Pipeline fixed

@uranusjr uranusjr merged commit a220486 into pypa:master Feb 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document the behavior of --cert
5 participants