Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change to pathlib for tests #9578

Closed
wants to merge 3 commits into from
Closed

Change to pathlib for tests #9578

wants to merge 3 commits into from

Conversation

pradyunsg
Copy link
Member

Closes #6050

@pradyunsg pradyunsg added the skip news Does not need a NEWS file entry (eg: trivial changes) label Feb 9, 2021
@pradyunsg pradyunsg mentioned this pull request Feb 9, 2021
Closed
@uranusjr
Copy link
Member

We’ll need to add a few str() casts.

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Feb 19, 2021
@pradyunsg pradyunsg force-pushed the drop-tests-lib-path branch from 9a3ed71 to b74a969 Compare April 1, 2021 21:47
@pypa-bot pypa-bot removed the needs rebase or merge PR has conflicts with current master label Apr 1, 2021
@pradyunsg
Copy link
Member Author

This should be good now. 🤞🏽

@pradyunsg
Copy link
Member Author

NOPE. Still more str casts apparently. :(

@BrownTruck
Copy link
Contributor

Hello!

I am an automated bot and I have noticed that this pull request is not currently able to be merged. If you are able to either merge the master branch into this pull request or rebase this pull request against master then it will be eligible for code review and hopefully merging!

@BrownTruck BrownTruck added the needs rebase or merge PR has conflicts with current master label Apr 3, 2021
@pradyunsg pradyunsg mentioned this pull request Aug 20, 2021
Merged
@pradyunsg
Copy link
Member Author

Closing since this has bitrotten. :(

@pradyunsg pradyunsg closed this Feb 25, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase or merge PR has conflicts with current master skip news Does not need a NEWS file entry (eg: trivial changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove tests.lib.path
4 participants
@pradyunsg @uranusjr @BrownTruck @pypa-bot