Handle standalone pip creation from pip wheel #9960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Actually I think maybe it’s best if we just remove the filename check altogether. If it’s gonna fail, it’s gonna fail either way, so the check doesn’t really mean much, now that I look at it. Just the |
|
Made the suggested change. |
uranusjr
approved these changes
May 7, 2021
|
I am guessing someone needs to approve the GitHub CI runs? |
uranusjr
reviewed
May 8, 2021
abn
force-pushed
the
issue/9953
branch
2 times, most recently
from
b5f1060 to
c5501f0
Compare
|
@uranusjr applied your suggestions as-is. |
This change ensures that when pip is executed from a wheel/zip, standalone pip creation for build environment reuses the source. Resolves: pypa#9953 Co-authored-by: Tzu-ping Chung <[email protected]>
uranusjr
approved these changes
May 9, 2021
|
Looks like GitHub actions might need another "Approve and run". |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that when pip is executed from a wheel/zip,
standalone pip creation for build environment reuses the source.
Resolves: #9953