Add tests for locking editable packages with ref #2939
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxltom
force-pushed
the
add-tests-for-ref-with-@-support
branch
from
3f31781 to
a350342
Compare
jxltom
force-pushed
the
add-tests-for-ref-with-@-support
branch
from
a350342 to
916ea7f
Compare
|
Update: it's ready for merge since #2940 has been merged |
techalchemy
added a commit
that referenced
this pull request
Oct 30, 2018
…' into merge-prs - Closes #2939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
Currently in master branch, following pipfile is not supported,
pipenv installwill throw errors.There are these kind of tests in previous pipenv version such as https://github.com/pypa/pipenv/pull/1128/files, but they are gone now for some reason. I didn't do the digging.
But it will be nice to add these tests to make sure that editable package with ref can be locked and installed correctly, and also to make sure that later development in codebase or in upstream won't break these featurres.
These tests added in this PR can pass only after sarugaku/requirementslib#76 is merged from upstrream.
The checklist
news/directory to describe this fix with the extension.bugfix,.feature,.behavior,.doc..vendor. or.trivial(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.