Enabled colors on native powershell #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Swap native blue for magenta - Fixes #3020 Signed-off-by: Dan Ryan <[email protected]>
Signed-off-by: Dan Ryan <[email protected]> Update crayons Signed-off-by: Dan Ryan <[email protected]> Fix crayons patch Signed-off-by: Dan Ryan <[email protected]> Fix crayons patch Signed-off-by: Dan Ryan <[email protected]>
techalchemy
force-pushed
the
update-crayons-patch
branch
from
9e1afa6 to
cb3b837
Compare
|
Maybe we can replace it with black? Use blue if the background is (persumably) something similar to black, and black if the background it blue. (This is probably a bad idea.) |
|
Magenta seems like the most likely to be visible (I ran this by kenneth earlier) The alternative is we can set a bgcolor, which we can still do-- going to merge this one for now and we can make that decision later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Dan Ryan [email protected]