Issue #3316: Include all deps in 'pipenv lock -r --dev' #4183
Conversation
* Implements PEEP-006 * `pipenv lock -r --dev` is now consistent with other commands and the CLI help output, and includes both default and dev dependencies in the result * New `--dev-only` option allows requesting the previous behaviour (which was specifically designed to support the traditional `requirements.txt`/`dev-requirements.txt` split)
pipenv/core.py
Outdated
| # Load the lockfile if it exists, or if only is being used (e.g. lock is being used). | ||
| if skip_lock or only or not project.lockfile_exists: | ||
| # Load the lockfile if it exists, or if dev_only is being used. | ||
| if skip_lock or dev_only or not project.lockfile_exists: |
There was a problem hiding this comment.
@techalchemy @frostming I'm not sure why dev_only (formerly called only) was ever in this conditional. To get PEEP 6 to work as intended, I think I may actually need to remove it, and follow the same branch as the regular non-dev requirements.
There was a problem hiding this comment.
Looking over the commit history for this, I have never touched this line which makes sense as I have no idea what this argument does. This is very confusing. If it is meant to be dev_only it wouldn't make any sense to skip locking...
Upon investigation, do_install_dependencies is only invoked by one caller and that caller does not pass this argument.
|
@techalchemy @frostming I don't think this is urgent (it doesn't need to go in the next release), making an initial attempt at implementing it just happened to make it to the top of my todo list today. |
pipenv/core.py
Outdated
| # Load the lockfile if it exists, or if only is being used (e.g. lock is being used). | ||
| if skip_lock or only or not project.lockfile_exists: | ||
| # Load the lockfile if it exists, or if dev_only is being used. | ||
| if skip_lock or dev_only or not project.lockfile_exists: |
There was a problem hiding this comment.
Looking over the commit history for this, I have never touched this line which makes sense as I have no idea what this argument does. This is very confusing. If it is meant to be dev_only it wouldn't make any sense to skip locking...
Upon investigation, do_install_dependencies is only invoked by one caller and that caller does not pass this argument.
|
Thanks for finishing it off! |
pipenv lock --dev --requirements#3316pipenv lock -r --devis now consistent with other commandsand the CLI help output, and includes both default and dev
dependencies in the result
--dev-onlyoption allows requesting the previous behaviour(which was specifically designed to support the traditional
requirements.txt/dev-requirements.txtsplit)requirementsvariables to use eitherrequirementstxtoremit_requirementsto make it clearer whether they're storing a reference to anactual requirements file, or a flag that says to emit the requirements information
without actually installing anything.
The checklist
news/directory to describe this fix with the extension.feature