bugfix 4388 to pipenv graph on windows #4409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please add a news fragment under the |
frostming
added
the
Status: Awaiting Update ⏳
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Pipenv!
The issue
F:\helloc\pipenv_proj\warpy_airtestpoco>PIPENV_EENV_IN_PROJECT\warpy_airtestpoco-OqiTcr_4\Scripts\pipenv graph
[PipenvCmdError]: File "f:\helloc\pipenv_proj\warpy_airtestpoco\pipenv_eenv_in_project\warpy_airtestpoco-oqitcr_4\lib\site-packages\pipenv\vendor\click\core.py", line 1259, in invoke
......
[PipenvCmdError]: File "f:\helloc\pipenv_proj\warpy_airtestpoco\pipenv_eenv_in_project\warpy_airtestpoco-oqitcr_4\lib\site-packages\pipenv\utils.py", line 161, in run_command
[PipenvCmdError]: raise PipenvCmdError(cmd_string, c.out, c.err, return_code)
Error running command: $ PIPENV_EENV_IN_PROJECT/warpy_airtestpoco-OqiTcr_4/Scripts/python.exe f:/helloc/pipenv_proj/warpy_airtestpoco/pipenv_eenv_in_project/warpy_airtestpoco-oqitcr_4/lib/site-packages/pipenv/vendor/pipdeptree.py -l
STDERR: 'PIPENV_EENV_IN_PROJECT' 不是内部或外部命令，也不是可运行的程序或批处理文件。
#4388
The fix
By debugging the code, i found that there is no need to call the function as_posix () for python_path and pipdeptree_path on the windows platform.
The checklist
The test