notpip is pip, Vendor in pip==22.2.1, standalone pipenv #5199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oz123
reviewed
Jul 28, 2022
| @@ -9,7 +9,7 @@ | |||
| try: | |||
| import importlib.metadata as imp_meta | |||
| except ImportError: | |||
| import pipenv.vendor.importlib_metadata as imp_meta | |||
| import importlib_metadata as imp_meta | |||
There was a problem hiding this comment.
We never fail here with ImportError. But it's still confusing that this was changed.
There was a problem hiding this comment.
I think I recall pondering about it because import pipenv.vendor.importlib_metadata doesn't exist -- It was confusing to me we would reference a fallabck import that does not exist.
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 10, 2023
Upstream `pipenv` renamed their internal patched version of `pip` folder to be called `patch.pip`: * pypa/pipenv#5199 So this updates our code as well.
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 18, 2023
Upstream `pipenv` renamed their internal patched version of `pip` folder to be called `patch.pip`: * pypa/pipenv#5199 So this updates our code as well.
jeffwidman
added a commit
to dependabot/dependabot-core
that referenced
this pull request
Aug 31, 2023
Upstream `pipenv` renamed their internal patched version of `pip` folder to be called `patch.pip`: * pypa/pipenv#5199 So this updates our code as well.
jurre
pushed a commit
to dependabot/dependabot-core
that referenced
this pull request
Sep 22, 2023
Upstream `pipenv` renamed their internal patched version of `pip` folder to be called `patch.pip`: * pypa/pipenv#5199 So this updates our code as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was branched from and supersedes this PR: #5193
Also supersedes this PR: #5196
which had one failing test that I decided to see if upgrading to the latest pip 22.2 would fix, and it has fixed it locally -- woo-hoo!
Fixes #5188
The issue
This accomplishes the following:
notpiptopipto be clear that its a patched version ofpip._post_pip_import.patchthat overrode the standalone pip to be the user installed pip -- and instead go with the patched import to use our vendor'd pip.pip==22.2.1This will allow for conversion off of some pip-shims, not needing pip installed to use pipenv (or having conflicting versions), and several bug fixes from the vendored dependencies