-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with unexpected package index resolution after upgrading pip to 22.3 #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fulfill index restrictions (default behavior).
oz123
requested changes
Oct 30, 2022
oz123
reviewed
Oct 30, 2022
oz123
reviewed
Oct 30, 2022
oz123
requested changes
Oct 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great that this is fixed, and along the way we uncover some undocumented Pipefile stuff.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue
After upgrading pip to 22.3 there were cases where users had multiple index defined and the resolution of which index to use changed during install causing hash validation to fail.
Fixes #5444
The fix
Technically it as never that correct to be passing all sources using extra index URLs when user has default behavior of
install_search_all_sources = false
--note: this won't fix what I believe to be a change in behavior to pip that may still cause issues for users that have
install_search_all_sources = true
however this brings the pipenv behaviors more in line with whats expected by ensuring complete isolation of the index assigned to each package.The checklist
news/
directory to describe this fix with the extension.bugfix.rst
,.feature.rst
,.behavior.rst
,.doc.rst
..vendor.rst
. or.trivial.rst
(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.