Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for Issue 4588 (path to python improvements) #5712

Merged
merged 7 commits into from
Jun 2, 2023
Merged

Fix for Issue 4588 (path to python improvements) #5712

merged 7 commits into from
Jun 2, 2023

Conversation

matteius
Copy link
Member

@matteius matteius commented May 31, 2023

Thank you for contributing to Pipenv!

The issue

Fixes #4588
Fixes #5714

The fix

Improve the code paths for:

  • Matching an existing path
  • using the line as a version specifier (improved regex)

The checklist

  • Associated issue
  • A news fragment in the news/ directory to describe this fix with the extension .bugfix.rst, .feature.rst, .behavior.rst, .doc.rst. .vendor.rst. or .trivial.rst (this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.

…ensions with latest manually (next pip vendoring will bring it in).
@oz123 oz123 merged commit 15c0ce0 into main Jun 2, 2023
@oz123 oz123 deleted the issue-4588 branch June 2, 2023 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new typing extensions supports python 3.12 Pipenv thinks a hidden path is a python version
2 participants