fix: when a resolution is failed show a helpful error #6338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix #6336 |
Also, exist the program immediately. For example: ``` $ pipenv install bottle==0.16.0 Installing bottle==0.16.0... ✔ Installation Succeeded Installing dependencies from Pipfile.lock (2110f5)... All dependencies are now up-to-date! Upgrading bottle==0.16.0 in dependencies. Building requirements... Resolving dependencies... ✘ Locking Failed! ⠼ Locking packages...CRITICAL:pipenv.patched.pip._internal.resolution.resolvelib.factory:Could not find a version that satisfies the requirement bottle==0.16.0 (from versions: 0.4.3, 0.4.4, 0.4.6, 0.4.7, 0.4.8, 0.4.9, 0.4.10, 0.4.11, 0.4.12, 0.4.13, 0.4.14, 0.5.3, 0.5.4, 0.5.6, 0.5.7, 0.5.8, 0.6.0, 0.6.1, 0.6.2, 0.6.3, 0.6.4, 0.6.5, 0.6.6, 0.8.1, 0.8.2, 0.8.3, 0.8.4, 0.8.5, 0.9.1, 0.9.2, 0.9.3, 0.9.4, 0.9.5, 0.9.6, 0.9.7, 0.9.8, 0.10.1, 0.10.2, 0.10.3, 0.10.4, 0.10.5, 0.10.6, 0.10.7, 0.10.8, 0.10.9, 0.10.10, 0.10.11, 0.10.12, 0.11.1, 0.11.2, 0.11.3, 0.11.4, 0.11.5, 0.11.6, 0.11.7, 0.12.1, 0.12.2, 0.12.3, 0.12.4, 0.12.5, 0.12.6, 0.12.7, 0.12.8, 0.12.9, 0.12.10, 0.12.11, 0.12.12, 0.12.13, 0.12.14, 0.12.15, 0.12.16, 0.12.17, 0.12.18, 0.12.19, 0.12.20, 0.12.21, 0.12.22, 0.12.23, 0.12.24, 0.12.25, 0.13.0, 0.13.1, 0.13.2) [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 451, in main [ResolutionFailure]: _main( [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 436, in _main [ResolutionFailure]: resolve_packages( [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 400, in resolve_packages [ResolutionFailure]: results, resolver = resolve_deps( [ResolutionFailure]: ^^^^^^^^^^^^^ [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 971, in resolve_deps [ResolutionFailure]: results, hashes, internal_resolver = actually_resolve_deps( [ResolutionFailure]: ^^^^^^^^^^^^^^^^^^^^^^ [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 735, in actually_resolve_deps [ResolutionFailure]: resolver.resolve() [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 460, in resolve [ResolutionFailure]: raise ResolutionFailure(message=e) Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies. You can use $ pipenv run pip install <requirement_name> to bypass this mechanism, then run $ pipenv graph to inspect the versions actually installed in the virtualenv. Hint: try $ pipenv lock --pre if it is a pre-release dependency. ERROR: No matching distribution found for bottle==0.16.0 ``` Or: ``` oznt@gentoo:/tmp/bla |pipenv-H8EVR25f| $ pipenv install noSuchDog Installing noSuchDog... ✔ Installation Succeeded Installing dependencies from Pipfile.lock (2110f5)... All dependencies are now up-to-date! Upgrading noSuchDog in dependencies. Building requirements... Resolving dependencies... ✘ Locking Failed! ⠹ Locking packages...CRITICAL:pipenv.patched.pip._internal.resolution.resolvelib.factory:Could not find a version that satisfies the requirement nosuchdog (from versions: none) [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 451, in main [ResolutionFailure]: _main( [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 436, in _main [ResolutionFailure]: resolve_packages( [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/resolver.py", line 400, in resolve_packages [ResolutionFailure]: results, resolver = resolve_deps( [ResolutionFailure]: ^^^^^^^^^^^^^ [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 971, in resolve_deps [ResolutionFailure]: results, hashes, internal_resolver = actually_resolve_deps( [ResolutionFailure]: ^^^^^^^^^^^^^^^^^^^^^^ [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 735, in actually_resolve_deps [ResolutionFailure]: resolver.resolve() [ResolutionFailure]: File "/home/oznt/Software/pypa/pipenv/pipenv/utils/resolver.py", line 460, in resolve [ResolutionFailure]: raise ResolutionFailure(message=e) Your dependencies could not be resolved. You likely have a mismatch in your sub-dependencies. You can use $ pipenv run pip install <requirement_name> to bypass this mechanism, then run $ pipenv graph to inspect the versions actually installed in the virtualenv. Hint: try $ pipenv lock --pre if it is a pre-release dependency. ERROR: No matching distribution found for nosuchdog ``` Signed-off-by: Oz Tiram <[email protected]>
oz123
force-pushed
the
better-error-messaeg-on-resolution-failure-6336
branch
from
6e8f196 to
5701434
Compare
fixes the failing test! Signed-off-by: Oz Tiram <[email protected]>
matteius
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, exist the program immediately.
For example:
Or:
Thank you for contributing to Pipenv!
The issue
What is the thing you want to fix? Is it associated with an issue on GitHub? Please mention it.
Always consider opening an issue first to describe your problem, so we can discuss what is the best way to amend it. Note that if you do not describe the goal of this change or link to a related issue, the maintainers may close the PR without further review.
If your pull request makes a significant change to Pipenv, such as the user interface or intended functionality, please open a discussion or issue report first.
The fix
How does this pull request fix your problem? Did you consider any alternatives? Why is this the best solution, in your opinion?
The checklist
news/directory to describe this fix with the extension.bugfix.rst,.feature.rst,.behavior.rst,.doc.rst..vendor.rst. or.trivial.rst(this will appear in the release changelog). Use semantic line breaks and name the file after the issue number or the PR #.