(🐞) Don't use repr for paths in console output
#1006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrysle
reviewed
Jun 20, 2023
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ | |||
| - Fallback to user's log path if the default log path (`$PIPX_HOME/logs`) is not writable to aid with pipx being used for multi-user (e.g. system-wide) installs of applications | |||
| - Fix wrong interpreter usage when injecting local pip-installable dependencies into venvs | |||
| - add pre-commit hook support | |||
| - Don't use `repr` for paths in console output | |||
There was a problem hiding this comment.
I don't think this is worth a changelog entry.
There was a problem hiding this comment.
I would add an entry, but not like this. It should say something about not showing double backslashes on Windows instead.
uranusjr
reviewed
Jun 20, 2023
KotlinIsland
force-pushed
the
fix/repr_path
branch
from
0084db1 to
72e748f
Compare
uranusjr
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/changelog.mdSummary of changes
Previously pipx would output things like
"File 'foo\\bar\\baz' not found.", which isn't ideal.reprto format paths shown in console #1003Test plan
Tested by running