fix: make Github Action safe to RCE via pull request title #1600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lociko
changed the title
huxuan
changed the title
huxuan
approved these changes
Feb 5, 2025
|
LGTM. Thanks for making pipx safer! Let us wait for other maintainers' review. |
dukecat0
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
A malicious actor can create a valid pull request that fixes a legitimate issue in the project. Once the issue is reviewed and the PR is approved before merging, the actor can change the PR title to something like:
Some PR "; printenv|base64 -d; echo "123This allows them to exfiltrate environment variables and potentially compromise sensitive data.
Test plan
Tested by running