Run a command from a [pipx.run] entry point #602
Conversation
uranusjr
force-pushed
the
run-custom-entry-points
branch
from
0455e99 to
b466125
Compare
| if isinstance(command, EntryPoint): | ||
| venv.run_entry_point(command, app_args) | ||
| else: | ||
| venv.run_app(app, app_args) |
There was a problem hiding this comment.
| venv.run_app(app, app_args) | |
| venv.run_app(command, app_args) |
gets changed on windows. Wish single dispatch method was available pre 3.8.
There was a problem hiding this comment.
It just occurs to me f"{app}.exe" is not actually needed. subprocess on Windows automatically resolves the extension (sine it is implemented with the CreateProcess Windows API).
There was a problem hiding this comment.
This never returns
Why are these not annotated NoReturn instead of None, by the way? Would need fewer comments and the type checker would check the validity of the no return status. Unrelated, just thought I'd ask here.
There was a problem hiding this comment.
Isn't the windows test failing because of this? Or is it just tripping a unit test?
There was a problem hiding this comment.
Why are these not annotated NoReturn instead of None, by the way?
Probably some legacy reasons, don’t know.
Isn't the windows test failing because of this? Or is it just tripping a unit test?
The test fails because it cannot find a line in the logs; cowsay itself seems to run fine.
There was a problem hiding this comment.
Pretty sure I wrote the None return values because I was not aware there was a NoReturn. Feel free to fix that.
|
What's the status of this? :) Edit, never mind, waiting on #606, I think. I should have asked about the status of that... |
|
Continuing in #615. |
docs/changelog.mdSummary of changes
Test plan
Tested by running