Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of deprecated setuptools features #181

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

pfmoore
Copy link
Member

@pfmoore pfmoore commented Dec 1, 2022

Removes mention of

  • data_files (package data is recommended)
  • scripts (entry points are recommended)
  • setup.py check (direct invocation of setup.py is deprecated)

Copy link
Member

@di di left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tox.ini Outdated
Comment on lines 36 to 38
# This repository uses a Markdown long_description, so the -r flag to
# `setup.py check` is not needed. If your project contains a README.rst,
# use `python setup.py check -m -r -s` instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this comment needs to be removed too?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed.

@pfmoore pfmoore merged commit db5806e into pypa:main Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants