-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use setup.cfg rather than setup.py. #96
Conversation
A setup.cfg is cleaner, is easy to parse, and does not require running any Python code. Its usage should be showcased.
So, setuptools >= 40.5.0 is required to use the "options.data_files" section. I wonder why it fails with the 3.5 image, and not the 2.7, 3.4 and 3.6 images. Any idea? |
@Steap Maybe because 3.5 is the only version not using |
@dmtucker Hm, setuptools 41.0.1 seems to be installed anyway. Why would not using pip-9.0.1 be an issue? |
Duplicated with #57 maybe we can find a way to introduce these changes together by merging delta between your changes and mine. I've propose these changes too early. |
If you were to build a wheel from project such as this from source, with an older version of setuptools installed then it would quietly, and happily output Since there are releases of Raspbian on the Pi that ship very old setuptools packages, I'm adopting a pattern like the below to catch that edge case. I wonder if it fits here too?
Note - updated code snippet with tweaks/fix from pimoroni/boilerplate-python@0060d76 |
You definitely don't want |
A setup.cfg is cleaner, is easy to parse, and does not require running
any Python code. Its usage should be showcased.