[pyproject.toml: part 4] Integrate pyproject.toml configuration into existing classes
#3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
c6907cb to
72fe662
Compare
abravalheri
force-pushed
the
integration
branch
from
ed2faf1 to
e102260
Compare
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
72fe662 to
5ef62fc
Compare
abravalheri
force-pushed
the
integration
branch
from
e102260 to
b37747b
Compare
2 tasks
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
5ef62fc to
bfb2ff2
Compare
abravalheri
force-pushed
the
integration
branch
from
b37747b to
1c63e19
Compare
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
bfb2ff2 to
9dcd88b
Compare
abravalheri
force-pushed
the
integration
branch
from
1c63e19 to
57b371f
Compare
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
9dcd88b to
5ecdb5b
Compare
abravalheri
force-pushed
the
integration
branch
from
57b371f to
f932de4
Compare
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
5ecdb5b to
c2b80aa
Compare
abravalheri
force-pushed
the
integration
branch
from
f932de4 to
b6556bc
Compare
abravalheri
changed the title
pyproject.toml: part 5] Integrate pyproject.toml configuration into existing classespyproject.toml: part 4] Integrate pyproject.toml configuration into existing classes
2 tasks
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
c2b80aa to
69ddad0
Compare
abravalheri
force-pushed
the
integration
branch
from
8ff43c1 to
99b8bd8
Compare
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
69ddad0 to
19b6ce2
Compare
abravalheri
force-pushed
the
integration
branch
from
99b8bd8 to
ced2741
Compare
abravalheri
added a commit
to abravalheri/setuptools
that referenced
this pull request
Feb 19, 2022
This change builds on top of the recently added ability to parse and apply configurations from TOML files to distribution objects by tapping into the existing mechanism for handling configuration and making these TOML files to be read by default. A series of deprecation warnings and tests is also added.
abravalheri
added a commit
to abravalheri/setuptools
that referenced
this pull request
Feb 20, 2022
This change builds on top of the recently added ability to parse and apply configurations from TOML files to distribution objects by tapping into the existing mechanism for handling configuration and making these TOML files to be read by default. A series of deprecation warnings and tests is also added.
abravalheri
added a commit
that referenced
this pull request
Feb 20, 2022
This change builds on top of the recently added ability to parse and apply configurations from TOML files to distribution objects by tapping into the existing mechanism for handling configuration and making these TOML files to be read by default. A series of deprecation warnings and tests is also added.
Since now setuptools supports 2 types of files for configuration
(`setup.cfg` and `pyproject.toml`), it is very trick to provide a single
`read_configuration` function that will provide compatible outputs for
both formats.
Instead the `config.{setupcfg,pyprojecttoml}` modules have their own
`read_configuration` functions that differ between themselves in terms
of arguments and format of the return value.
Therefore the users should be importing directly the specific submodule
and calling the read function from there.
The `config.setupcfg` submodule is advertised as "provisional" in the
deprecation note because the main proposal debated in the setuptools
issue tracker reached some level of consensus around deprecating
`setup.cfg` files.
… as suggested in code review
This is a regression test for a problem identified in: #2970 (comment)
These tests were initially motivated by a discussion in: pybind/pybind11#3711 (comment)
abravalheri
force-pushed
the
dist-config-from-pyproject
branch
from
979596a to
0497954
Compare
abravalheri
added this to the Add experimental support for project metadata via `pyproject.toml` milestone
Base automatically changed from
dist-config-from-pyproject
to
support-pyproject-aggregate
March 18, 2022 10:09
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change builds on top of the recently added ability to parse and apply configurations from TOML files to distribution objects by tapping into the existing mechanism for handling configuration and making these TOML files to be read by default.
A series of deprecation warnings and tests is also added.
Summary of changes
pyproject.tomltodist.parse_config_files- b12b9d7PendingDeprecationWarningforsetup.cfg- 5baed64pyproject.toml-based configs - b9ddb59pyproject.tomlmetadata - e991760xfail- 9179116Some individual commits have a more detailed explanation for the change, please refer to the commit text if more information/context is needed
Pull Request Checklist
changelog.d/.(See documentation for details)