Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sdist: Add files from build subcommands (get_source_files) #3412

Merged
merged 2 commits into from
Jun 25, 2022
Merged

sdist: Add files from build subcommands (get_source_files) #3412

merged 2 commits into from
Jun 25, 2022

Conversation

abravalheri
Copy link
Contributor

(Another PR of the PEP 660 series)

Summary of changes

  • Expand the API defined for custom sub-commands by documenting get_source_files()
    • This function is already defined for all existing build_* subcommands. We are just asking custom implementations to also honour this interface.
  • Add the return value of get_source_files() to the file list created in sdist.

Closes

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review June 25, 2022 15:00
@abravalheri abravalheri merged commit 2ee94e7 into pypa:feature/pep660 Jun 25, 2022
@abravalheri abravalheri deleted the update-sdist-command branch June 25, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abravalheri