Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid using SETUPTOOLS_EDITABLE env var in test #3479

Merged
merged 1 commit into from
Aug 3, 2022
Merged

Avoid using SETUPTOOLS_EDITABLE env var in test #3479

merged 1 commit into from
Aug 3, 2022

Conversation

abravalheri
Copy link
Contributor

@abravalheri abravalheri commented Aug 2, 2022 •
edited
Loading

(Another PR related to the PEP 660 implementation, carried out in the feature/pep660 branch)

Summary of changes

  • Now that pip supports --config-settings for editable installs setting the environment var SETUPTOOLS_EDITABLE is no longer necessary, and the tests should not rely on it.

Closes

Pull Request Checklist

@abravalheri abravalheri marked this pull request as ready for review August 2, 2022 19:39
@abravalheri abravalheri merged commit 4b8a6e0 into pypa:feature/pep660 Aug 3, 2022
@abravalheri abravalheri deleted the remove-env-var-dependency branch August 3, 2022 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@abravalheri