Attempt to avoid error with _read_utf8_with_fallback by moving code in pkg_resources
#4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
In #4399 there is a strange error when
pkg_resources/__init__.pytries to reach_read_utf8_with_fallback.Unfortunately, still there is no minimal reproducer for this problem, so I am not sure what is the root cause of the problem. However, there is some indication that simply re-ordering the definition of the function before the calls with
_call_aside, may help with the problem.Since there is no change in implementation (just re-ordering), we might as well try.
Other changes in this PR:
LOCALE_ENCODING=>_LOCALE_ENCODING: that is an oversight of the previous PR, it is better to keep the member private while the change is too new for people to start depending on it (Hyrum's law).Closes
Pull Request Checklist
newsfragments/.(See documentation for details)