Avoid type issues with _build_ext being Any
#4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avasam
commented
Aug 26, 2024
| @@ -183,12 +183,11 @@ def get_build_ext_cmd(self, optional: bool, **opts): | |||
| "eggs.c": "#include missingheader.h\n", | |||
| ".build": {"lib": {}, "tmp": {}}, | |||
| } | |||
| path.build(files) | |||
| path.build(files) # type: ignore[arg-type] # jaraco/path#232 | |||
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
When
Cython.Distutils.build_extis not installed,_build_extisAnywhich trickles down issues. Like being an invalid type to subclass, missing attributes, always matching the first overload, etc.Pull Request Checklist
newsfragments/. (not user facing yet)(See documentation for details)