-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "Wheel naming is not following PEP 491 convention" #4766
base: main
Are you sure you want to change the base?
Conversation
Thank you! The failing test seems to be happening now regardless of this change: https://github.com/pypa/setuptools/actions/runs/12298183072/job/34321035714#step:3:49. I don't know if anything changed in the latest versions of Python being distributed to macOS, so that |
Aha, that's a different failure actually, |
92d42d1
to
c1bf7c7
Compare
This looks like it is checking deprecated functionality? Not sure we have to account such an edge case since we are moving away from |
I'm not sure! I think the test is just broken in a way I haven't been able to figure out (it mixes the distribution name and the namespace name as one thing in the helper functions) but I think the underlying functionality probably still works? |
All tests are passing, this is now ready for review. |
Summary of changes
Fixes #3777.
Marking this as draft as there is one outstanding failing test that I have been unable to resolve (
setuptools/tests/test_easy_install.py::TestSetupRequires::test_setup_requires_override_nspkg
).Pull Request Checklist
newsfragments/
.(See documentation for details)