Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add python_requires keywords to setup #631

Merged
merged 3 commits into from
Jul 20, 2016
Merged

Add python_requires keywords to setup #631

merged 3 commits into from
Jul 20, 2016

Conversation

xavfernandez
Copy link
Member

@xavfernandez xavfernandez commented Jul 9, 2016 •
edited
Loading

This should allow setuptools to write the metadata Requires-Python and
Requires-External from PEP345 to the PKGINFO file

Looking for validation on the idea before improving it (docs and tests).
Are python_requires and external_requires the right keywords, or should they be requires_python and requires_external ?

This would enable me to revive pypa/pip#3640 using Requires-Python info.

cc @dstufft

@dstufft
Copy link
Member

dstufft commented Jul 9, 2016

I don't think I would add the external stuff, I don't think it's generally useful and I think that we would want to avoid shipping that to people since it doesn't have much use.

Totally on board with adding Requires-Python though.

@xavfernandez xavfernandez changed the title [WIP] Add python/external_requires keywords to setup Add python_requires keywords to setup Jul 11, 2016
@xavfernandez
Copy link
Member Author

external_requires removed and 2 basic tests added.
Feedback welcome :-)

@xavfernandez
Add python/external_requires keywords to setup
9847746 
This should allow setuptools to write the metadata Requires-Python and
Requires-External from PEP345 to the PKGINFO file
@xavfernandez
Drop external_requires keyword
d9a251b
@xavfernandez
Add basic tests and docs for python_requires
020771f
@xavfernandez xavfernandez force-pushed the xfernandez/python_requires branch from 015d291 to 020771f Compare July 14, 2016 08:09
@xavfernandez
Copy link
Member Author

@jaraco any feedback ?

@jayvdb
Copy link
Contributor

jayvdb commented Jul 14, 2016

Why is setuptools rejecting implementation of parts of an accepted PEP ? Should the PEP be edited?

@xavfernandez xavfernandez mentioned this pull request Jul 14, 2016
Merged
@jaraco
Copy link
Member

jaraco commented Jul 14, 2016

I haven't had a chance to review. I'll try to get to it soon. Ping me in a week if you haven't heard anything.

@dstufft
Copy link
Member

dstufft commented Jul 14, 2016

@jayvdb Because it was never implemented, will likely be replaced in the future, and is a needless footgun.

@dstufft dstufft mentioned this pull request Jul 14, 2016
Closed
@jaraco
Copy link
Member

jaraco commented Jul 20, 2016

Looks good to me. Let's give it a go.

@jaraco jaraco merged commit b2f50d5 into pypa:master Jul 20, 2016
@xavfernandez
Copy link
Member Author

Oh
Happy to see it merged, but it looks like I did not push my latest change for the Metadata-Version update, I'll push it via an other PR in an hour.

@xavfernandez xavfernandez mentioned this pull request Jul 21, 2016
Closed
@xavfernandez xavfernandez deleted the xfernandez/python_requires branch July 21, 2016 08:50
brechtm added a commit to brechtm/rinohtype that referenced this pull request Aug 11, 2016
@brechtm
Make use of the 'python_requires' setup argument
f640147 
In the future, this will prevent installation on unsupported Python
versions (pypa/setuptools#631).
rgommers added a commit to rgommers/numpy that referenced this pull request Apr 15, 2017
@rgommers
REL: add python_requires to setup.py
343de6f 
This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
@rgommers rgommers mentioned this pull request Apr 15, 2017
Merged
rgommers added a commit to rgommers/scipy that referenced this pull request Apr 18, 2017
@rgommers
REL: add python_requires to setup.py, fix Python version check.
c00c2dd 
This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
@rgommers rgommers mentioned this pull request Apr 18, 2017
Merged
perimosocordiae pushed a commit to scipy/scipy that referenced this pull request Apr 18, 2017
@rgommers @perimosocordiae
REL: add python_requires to setup.py, fix Python version check. (#7313
afac0f6 
)

This allows pip to figure out the last compatible version
with a particular Python version before attempting to
install.

Support for this field was added to setuptools last year:
pypa/setuptools#631
@aragilar aragilar mentioned this pull request Oct 12, 2017
Merged
@rmorshea rmorshea mentioned this pull request Jun 14, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xavfernandez @dstufft @jayvdb @jaraco