-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Further fix for #1339 (--python option) #1364
Conversation
Hmm, I'm getting test errors saying "ERROR: target path contains the operating system path separator ';'". That doesn't seem related to my change (and I think there was a recent change merged to do with that). So is there some other issue with master? @gaborbernat Having said that, there do seem to be some issues with my code - but I'm not clear what yet. I'm working on those :-) |
Thanks for the fast merge! |
I thank you for the fast fix. Release will take a week or two as I'm in middle of multiple major changes. Will be inside release 17.0.0 though 😁 |
No worries, it's been hitting me personally, so I was well motivated to find a fix :-) And I can use the version from github until the release arrives, so we're good there. |
FYI will move to src layout soon, so use pep-517+518 to install from GitHub 😁 |
Awesome, just did some debugging / spelunking to find this solves the issue I'm seeing as well in pre-commit/pre-commit#1046 looking forward to the release! fwiw my reproduction was a little more involved for whatever reason:
|
I'll release tomorrow as a patch release 👌 |
No description provided.