Include '--index-url' argument for the pip install command for Test PyPI #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template logic for a package's pip installation command has been moved to a jinja macro called `pip_command`. This macro furthermore determines whether or not to add the Test PyPI's `--index-url` based on the existence of the *testPyPI* variable.
|
Builds are failing due to missing itsdangerous==1.0.0, fixed in #4940 |
di
reviewed
Oct 27, 2018
|
|
||
| {%- macro pip_command(release, request_route, test_environment) -%} | ||
| {%- if test_environment -%} | ||
| {% set index_url = " --index-url https://test.pypi.org/simple/" %} |
There was a problem hiding this comment.
Could shorten this a bit by using -i instead of --index-url.
I agree it's a bit weird, but I think I'd rather have it look a bit weird than have a smaller font. Also since this is only on TestPyPI and eventually TestPyPI will go away, I think it's OK! |
|
It's not that bad with
might depend on the name of the package though |
di
approved these changes
Oct 27, 2018
nlhkabu
approved these changes
Oct 28, 2018
This was referenced Oct 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@krf2 thanks for your PR, as part of the Bloomberg sprint I picked it up, but is a little out of date and it felt easier to just cherry pick your commit on this PR, I hope you don't mind.
This is what it looks like atm:
Looks a bit weird imho maybe we should reduce the font size? @nlhkabu what do you think?