Simple navigation show, restore the LeftToRightAndBack show #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sul3n3t
approved these changes
Aug 18, 2019
| @@ -41,7 +41,7 @@ class Cell(NamedTuple): | |||
| orientation: Orientation | |||
| addresses: List["Address"] | |||
|
|
|||
| row_count = 11 | |||
| row_count = 11 #why is this hard coded? (jem) | |||
| @@ -11,7 +11,7 @@ def __init__(self, grid, frame_delay=0.1): | |||
| self.grid = grid | |||
| self.frame_delay = frame_delay | |||
|
|
|||
| # from IPython import embed; embed() | |||
| from IPython import embed; embed() | |||
There was a problem hiding this comment.
Probably meant to keep this commented out for master.
| while True: | ||
| hsv = HSV(1.0, 1, 1) | ||
|
|
||
| for row in range (0,11): |
There was a problem hiding this comment.
After #19 merged, you can do (if you want):
for row in range(self.grid.rows):
for col in range(self.grid.geom.row_length(row)):
self.grid.set(Position(row, col), hsv)
| a_ctr = 0 | ||
| for points in traversal.left_to_right(n_rows): | ||
| for (row, col) in points: | ||
| cell = self.grid.select(Position(row=row,col=col)) |
There was a problem hiding this comment.
This can be cell = self.grid[Position(row, col)] and you don't have to do cell[0] after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.