-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added additional details to Java integration #169
Merged
Rperry2174
merged 5 commits into
pyroscope-io:main
from
6fears7:update/java/springboot-setup
Apr 10, 2023
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
abae1f3
Added additional details to Java integration
6fears7 e29df7b
Updated with suggested fixes
6fears7 854f2db
Updated with suggested fixes
6fears7 b9443dc
Adds tabgroups to java documentation page
Rperry2174 12b50a7
Merge branch 'update/java/springboot-setup' of https://github.com/6fe…
Rperry2174 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
export const exampleGradle = `implementation("io.pyroscope:agent:\${pyroscope_version}")` | ||
|
||
export const exampleMaven = `<dependency> | ||
<groupId>io.pyroscope</groupId> | ||
<artifactId>agent</artifactId> | ||
<version>pyroscope_version</version> | ||
</dependency>` | ||
|
||
export const examplePlainJava = `PyroscopeAgent.start( | ||
new Config.Builder() | ||
.setApplicationName("ride-sharing-app-java") | ||
.setProfilingEvent(EventType.ITIMER) | ||
.setFormat(Format.JFR) | ||
.setServerAddress("http://pyroscope-server:4040") | ||
// Optionally, if authentication is enabled, specify the API key. | ||
// .setAuthToken(System.getenv("PYROSCOPE_AUTH_TOKEN")) | ||
.build() | ||
);` | ||
|
||
export const exampleSpringFramework = `import io.pyroscope.javaagent.PyroscopeAgent; | ||
import io.pyroscope.javaagent.config.Config; | ||
import io.pyroscope.javaagent.EventType; | ||
import io.pyroscope.http.Format; | ||
|
||
@PostConstruct | ||
public void init() { | ||
|
||
PyroscopeAgent.start( | ||
new Config.Builder() | ||
.setApplicationName("ride-sharing-app-java") | ||
.setProfilingEvent(EventType.ITIMER) | ||
.setFormat(Format.JFR) | ||
.setServerAddress("http://pyroscope-server:4040") | ||
// Optionally, if authentication is enabled, specify the API key. | ||
// .setAuthToken(System.getenv("PYROSCOPE_AUTH_TOKEN")) | ||
// Optionally, if you'd like to sets allocation threshold to register events, in bytes. '0' registers all events | ||
// .setProfilingAlloc("0") | ||
6fears7 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
.build() | ||
); | ||
}` |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@petethepig how do we make this variable actually substitute in here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe out of scope for this pr though, happy to create an issue and address later if you think thats better