build: fix linter (#12)

After a lot of debugging I noticed that the `envstub` call wasn't
working properly (couldn't figure out why), replaced for an action that
does the same thing.

Also disable `strict` mode, since now we have warnings.

.github/actions/lint-plugin/action.yaml

@@ -9,18 +9,23 @@ inputs:
 runs:
   using: "composite"
   steps:
+  - name: Render Deployment YAML
+    uses: nowactions/envsubst@v1
+    with:
+      input: ./lint.config.yaml.tmpl
+      output: ./lint.config.yaml
+    env:
+      ENABLE_VERSION_ANALYZER: ${{ inputs.enable-version-analyzer }}
   - name: Lint plugin
     shell: bash
     run: |
       export PATH="$(go env GOPATH)/bin/:$PATH"
-      envsubst < lint.config.yaml > lint.config.yaml
       git clone https://github.com/grafana/plugin-validator
       pushd ./plugin-validator/pkg/cmd/plugincheck2
       go install
       popd
 
-      plugincheck2 -strict -config lint.config.yaml -sourceCodeUri=file://./ ${{ inputs.file }}
+      plugincheck2 -config lint.config.yaml -sourceCodeUri=file://./ ${{ inputs.file }}
     env:
-      ENABLE_VERSION_ANALYZER: ${{ inputs.enable-version-analyzer }}
       DEBUG: 1
 

.github/workflows/ci.yml

@@ -13,12 +13,12 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup-node/
-      - run: yarn sign
       - uses: ./.github/actions/package-plugin/
         id: package-plugin
         with:
           grafana-token: ${{ secrets.GRAFANA_API_KEY }}
       - uses: ./.github/actions/lint-plugin/
         with:
           file: ${{ steps.package-plugin.outputs.archive }}
+          # in PRs the version won't be correct, so there's no point checking it
           enable-version-analyzer: false

.github/workflows/release.yml

@@ -12,7 +12,6 @@ jobs:
     steps:
       - uses: actions/checkout@v3
       - uses: ./.github/actions/setup-node/
-      - run: yarn sign
       - uses: ./.github/actions/package-plugin/
         id: package-plugin
         with:

CONTRIBUTING.md

@@ -2,7 +2,7 @@
 
 ## Releasing new versions
 1. Merge the PR created by `Release Please`
-2. Open [https://grafana.com/orgs/pyroscope/plugin-submissions/pyroscope-panel](https://grafana.com/orgs/pyroscope/plugin-submissions/pyroscope-datasource) and submit the plugin, copying the links from this repository's releases.
+2. Open [https://grafana.com/orgs/pyroscope/plugin-submissions/pyroscope-panel](https://grafana.com/orgs/pyroscope/plugin-submissions/pyroscope-panel) and submit the plugin, copying the links from this repository's releases.
 
 ## Fixing releases
 After submitting to Grafana, they may find issues.

lint.config.yaml.tmpl

@@ -0,0 +1,12 @@
+global:
+  enabled: true
+  jsonOutput: false
+  reportAll: false
+
+analyzers:
+  version:
+    enabled: ${ENABLE_VERSION_ANALYZER}
+  trackingscripts:
+    # there's a false positive happening
+    # TODO: update after https://github.com/grafana/plugin-validator/issues/105 is fixed
+    enabled: false