Skip to content

Commit

Permalink
Expand test rig to Python 3.8
Browse files Browse the repository at this point in the history
  • Loading branch information
@jayvdb
jayvdb committed Aug 13, 2020
1 parent 0b90288 commit 850e40f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions .travis.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ python:
- "3.4"
- "3.5"
- "3.6"
- "3.7"
- "3.8"

This comment has been minimized.

Sign in to view

Copy link
@PhilippSelenium

PhilippSelenium Nov 13, 2020 •
edited
Loading

Contributor

@jayvdb @nicoddemus I'm very suspiciuos about this commit and have doubts that it works with python 3.8 and 3.7
because when running locally with tox I get two of the same errors mentioned in #15 (It works for py36)

FAILED tests/test_script.py::Test2Args::test_add_parens - AssertionError: assert 'assert (not a) == c\n' == 'assert not a == c\n'
FAILED tests/test_script.py::Test3Args::test_add_parens - AssertionError: assert 'assert abs((... d)) <= 0.1\n' == 'assert abs(a... d)) <= 0.1\n'

I do not know anything about how travis works but shouldn't the call below just be script: tox?

This comment has been minimized.

Sign in to view

Copy link
@jayvdb

jayvdb Nov 14, 2020

Author Contributor

No idea about your problems , but I can assure you these tests work well on Python 3.8 - The Tumbleweed builds here are working in isolated VMs with only Python 3.8 and very few other dependencies installed.
https://build.opensuse.org/package/show/devel:languages:python/python-nose2pytest

tox adds more things to your Python environment, and that can introduce problems. Not suggesting that is your problem, but it is a reason to avoid tox unless virtualised environments with varying dependencies are needed, as that is the primary benefit of tox.

install:
- pip install .
Expand Down
2 changes: 1 addition & 1 deletion tox.ini
View file
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[tox]
envlist = py34, py35, py36
envlist = py34, py35, py36, py37, py38

[testenv]
deps =
Expand Down

0 comments on commit 850e40f

Please sign in to comment.