Always define __version__ even if get_distribution() fails #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In frozen executables such as pyinstaller, get_distribution() does not work because it looks for files in the environment which are not packed in the executable. This patch makes `__version__` available in those situations, otherwise the plugin won't work at all because `plugin.py` tries to import `__version__` from `pytest_html.__init__`.
davehunt
approved these changes
Sep 18, 2018
|
Taking the liberty of merging Dave! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In frozen executables created with tools such as pyinstaller, get_distribution() does not work because it looks for files in the environment which are not packed in the
executable.
This patch makes
__version__available in those situations, otherwise theplugin won't work at all because
plugin.pytries to import__version__from
pytest_html.__init__.