Drop support for legacy Python 2.7

[hugovk]

Fixes #228.

[BeyondEvil]

Awesome job! Thanks for this!

I'm not sure how to handle the merge however. It is after all a couple of months left before 2.7 is EOL.
@davehunt @rochacbruno

[hugovk]

Thanks for the review, updated!

---

I'm not sure how to handle the merge however. It is after all a couple of months left before 2.7 is EOL.

To compare with pytest itself:

• Pytest 5.x is the master branch, and no longer supports Python 2.7.

• The pytest core team will make bug fixes to pytest 4.6 until January 2020, and will accept and release community patches until mid-2020:

• https://docs.pytest.org/en/latest/py27-py34-deprecation.html

[BeyondEvil]

Sorry that I didn't catch all those the previous round. 😞

[BeyondEvil]

Good job on the changes! Discovered some more, sorry about that.

Thanks for the review, updated!

I'm not sure how to handle the merge however. It is after all a couple of months left before 2.7 is EOL.

To compare with pytest itself:

* Pytest 5.x is the master branch, and no longer supports Python 2.7.

* The pytest core team will make bug fixes to pytest 4.6 until January 2020, and will accept and release community patches until mid-2020:

* https://docs.pytest.org/en/latest/py27-py34-deprecation.html

Not a bad idea. I guess we can have a twodotseven-branch for the same purpose.

But I want someone else to chime in before I make it so. @davehunt @rochacbruno

[RibeiroAna]

@BeyondEvil my opinion is that we should launch Pytest-HTML 2.0 with this patch and people who still need to use Python 2.7 during the remaining months until its dead should use Pytest-HTML 1.x

[BeyondEvil]

@BeyondEvil my opinion is that we should launch Pytest-HTML 2.0 with this patch and people who still need to use Python 2.7 during the remaining months until its dead should use Pytest-HTML 1.x

I agree. I'm just not sure how to handle the practical aspects.

[RibeiroAna]

@BeyondEvil I'm not sure which practical aspects you mean! Maybe launch Pytest 1.23.0 that includes a deprecation alert on the HTML file? (I don't think it is worthy)

[BeyondEvil]

@BeyondEvil I'm not sure which practical aspects you mean! Maybe launch Pytest 1.23.0 that includes a deprecation alert on the HTML file? (I don't think it is worthy)

Well, if master is going to be 2.x, we'll need a 1.x-"master"-branch, and I'm not sure if either of us can create that or if only @davehunt can do it.

And I agree, not worth releasing a 1.x version with just a deprecation warning. pytest itself already does that.

[BeyondEvil]

Probably a good idea to not allow a pytest version that supports 2.7

[hugovk]

Thanks for the new reviews! I'm travelling right now and can update these later this week. Or feel free to update this branch.

The python_requires=">=3.6", here helps with some of the practical aspects. It means people (with modern pip) who install the package will only get this version if their Python version matches. Otherwise pip'll check each older one until it finds one that matches (or has no python_requires). So 2.7 users will get the last one to support 2.7.

https://python3statement.org/practicalities/ has some other suggestions, but I think python_requires is the most important.

[BeyondEvil]

@hugovk No worries, there's no stress! We're not fixing anything that is broken.

Safe travels!

[hugovk]

Updated!

[davehunt]

I'd say let's release this as pytest-html 2.0 and create a 1.22-maintenance branch, following the same approach as pytest, and only uplifting bugfixes to that branch and releasing 1.22.x as needed. I don't expect there will be many (if any) patches that will require a 1.22.x release though, and we should strongly encourage users to upgrade to Python 3.