Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support utf8 display #244

Merged
merged 3 commits into from
Nov 5, 2019
Merged

Support utf8 display #244

merged 3 commits into from
Nov 5, 2019

Conversation

lzhu666
Copy link
Contributor

@lzhu666 lzhu666 commented Oct 11, 2019

Support utf8 display

[before]：
TestForSyncProduct::test_1_valueValid[test Case Name-add]
TestForSyncProduct::test_2_valueValid[\u6d4b\u8bd5\u7528\u4f8b\u540d\u79f0-update]

[now]：
TestForSyncProduct::test_1_valueValid[test Case Name-add]
TestForSyncProduct::test_2_valueValid[测试用例名称-update]

@lzhu666
Update plugin.py
f251cea 
Support Chinese display

[before]：
TestForSyncProduct::test_1_valueValid[test Case Name-add]  
TestForSyncProduct::test_2_valueValid[\u6d4b\u8bd5\u7528\u4f8b\u540d\u79f0-update]

[now]：
TestForSyncProduct::test_1_valueValid[test Case Name-add]
TestForSyncProduct::test_2_valueValid[测试用例名称-update]
rochacbruno
rochacbruno previously approved these changes Oct 11, 2019
View reviewed changes
BeyondEvil
BeyondEvil requested changes Oct 12, 2019
View reviewed changes
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for this!

Could you please add a test as well?

Thanks again! 👍

@BeyondEvil
Copy link
Contributor

Ping @lzhu666

I'd love to make a release ASAP and I would like for this to be included. But I want a test for it please. 🙏

@lzhu666
Copy link
Contributor Author

lzhu666 commented Nov 5, 2019

Ping @lzhu666

I'd love to make a release ASAP and I would like for this to be included. But I want a test for it please. 🙏

utf8Display.zip
please execute : pytest test_utf8Display.py --html=./report/report.html
Thanks!

@BeyondEvil
Copy link
Contributor

Ping @lzhu666
I'd love to make a release ASAP and I would like for this to be included. But I want a test for it please. 🙏

utf8Display.zip
please execute : pytest test_utf8Display.py --html=./report/report.html
Thanks!

@lzhu666 Thanks, but what I meant was to add a test to the project. 😊

Also, this is out of sync with master and so needs an update.

Thanks! 🙏

@lzhu666
Copy link
Contributor Author

lzhu666 commented Nov 5, 2019

Ping @lzhu666
I'd love to make a release ASAP and I would like for this to be included. But I want a test for it please. 🙏

utf8Display.zip
please execute : pytest test_utf8Display.py --html=./report/report.html
Thanks!

@lzhu666 Thanks, but what I meant was to add a test to the project. 😊

Also, this is out of sync with master and so needs an update.

Thanks! 🙏

I've added test, and already in sync with master.
Thanks!

@BeyondEvil BeyondEvil merged commit 2c78ca7 into pytest-dev:master Nov 5, 2019
@ssbarnea ssbarnea added the bug This issue/PR relates to a bug. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BeyondEvil BeyondEvil BeyondEvil approved these changes

@rochacbruno rochacbruno rochacbruno left review comments

Assignees
No one assigned
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lzhu666 @BeyondEvil @rochacbruno @ssbarnea