Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra fixture #269

Merged
merged 1 commit into from
Feb 29, 2020
Merged

Conversation

christiansandberg
Copy link
Contributor

Adds a fixture, extra, which can be used to add extra content directly in a test function without having to implement hooks.

@BeyondEvil
Copy link
Contributor

Thanks for this! Mind updating the branch with master? @christiansandberg

@BeyondEvil
Copy link
Contributor

Mind squashing/fixup commits so we can get this merged @christiansandberg ?

BeyondEvil
BeyondEvil previously approved these changes Feb 28, 2020
Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christiansandberg
Copy link
Contributor Author

You can just squash merge the pull request.

@christiansandberg
Copy link
Contributor Author

But if you prefer to have a merge commit I can do that. I just realized one thing I need to test first...

@BeyondEvil
Copy link
Contributor

But if you prefer to have a merge commit I can do that. I just realized one thing I need to test first...

Yes, please. 😊

Also, might be a good idea to mention precedence/order in the docs. 👍

Copy link
Contributor

@BeyondEvil BeyondEvil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good! 👍

@BeyondEvil BeyondEvil merged commit 47c2a8e into pytest-dev:master Feb 29, 2020
@BeyondEvil
Copy link
Contributor

Released in v2.1.0

@ssbarnea ssbarnea added the enhancement This issue/PR relates to a feature request. label Aug 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants