Fix embedded images (and videos) #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I'm going to try to look at these today. As soon as #299 is merged, you can rebase and the tests should pass. |
|
So, see comments here: #277 Nice work on this and the excellent troubleshooting you did both here and over at pytest-selenium (coincidentally I'm the maintainer for that too 😄). Much appreciated! |
|
@BeyondEvil - 👍 |
This is for pytest-dev/pytest-selenium#237. My original change was redundant with #277, so just update tests and acknowledgements for the author of #277, the author of #287, and the reporters of #265 and pytest-dev/pytest-selenium#237.
|
Rebased and updated commit message |
BeyondEvil
approved these changes
May 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #265 and related pytest-dev/pytest-selenium#237.
In #260, one of the three paths through the new
_make_media_html_divlost the ability to embed its inner content. This PR adds tests for that (first commit, they failed) and adds back the embedding (second commit).This change is