Assure scm versioning is pypa compatible #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnikonorov
reviewed
Nov 4, 2020
| "pip >= 19.3.1", | ||
| "setuptools >= 42", | ||
| "setuptools_scm[toml] >= 3.5.0", | ||
| "setuptools_scm_git_archive >= 1.1", |
There was a problem hiding this comment.
Out of curiosity, why do we need to add all these requirements for this change?
gnikonorov
approved these changes
Nov 4, 2020
|
TBH, I am not sure if all these are required but if they are not yet, they will soon be. Based on how pip is called and its own version it can decide to use very different methods for installing. This addresses some other issues people may encounter. Keep in mind that these are build time requirements, something very different that runtime requirements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of releasing test.pypi.org containers that were not tagged by making the versioning compatible with publishing requirements (taken from other places where I am using it, mainly avoids using
+in version and instead produces something like2.1.2.dev47which is accepted.Related: #322 (comment)