refactor: stop overwriting pytest data #597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BeyondEvil
force-pushed
the
beyondevil/move-test-data-from-top-level
branch
2 times, most recently
from
48d9f86 to
d3db0bc
Compare
BeyondEvil
force-pushed
the
beyondevil/move-test-data-from-top-level
branch
from
3626771 to
aac5532
Compare
BeyondEvil
added a commit
to BeyondEvil/pytest-html
that referenced
this pull request
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were overwriting some of the attributes coming out of pytest (like
nodeid) and since this data is shared with other plugins, that's a bad idea.This PR aims to fix that.